Fix log_call! macro example in "Rust for Python Programmers" (ch12 closures and iterators)#84
Open
Chandan-Kalita wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix log_call! macro example in "Rust for Python Programmers" (ch12 closures and iterators)#84Chandan-Kalita wants to merge 1 commit intomicrosoft:mainfrom
Chandan-Kalita wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in the log_call! macro where it expands to multiple statements instead of a single expression, causing a type mismatch in usage.
Problem
The macro was defined as:
When used in expression position:
it expands to:
This results in a compilation error:
expectedString, found()because the macro does not expand to a single expression.
Fix
Wrap the macro body in a block expression:
This ensures the macro expands to a single expression whose value is the result of $body.
Result