Modernize the ranges::find family #1058
Merged
+277
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Jul 20, 2020
CaseyCarter
approved these changes
Jul 21, 2020
StephanTLavavej
requested changes
Jul 22, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, just nitpicks!
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
StephanTLavavej
approved these changes
Jul 22, 2020
CaseyCarter
approved these changes
Jul 22, 2020
Contributor
|
Thanks for locating things to cleanup in |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 28, 2020
Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
ranges::find*algorithms to the latest way of implementing the algorithms.It also updates all tests except
find_endas there was a strange issue I need to understand.