feature/spaceship: Clause 20: pair, tuple, optional #1206
Merged
+251
−291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug uncovered by fixed tests.
Co-authored-by: Casey Carter <Casey@Carter.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
cbezault
force-pushed
the
feature/spaceship/utility
branch
from
d972c0a to
144f0d3
Compare
cbezault
force-pushed
the
feature/spaceship/utility
branch
from
70fdd7a to
33f023b
Compare
StephanTLavavej
changed the title
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I'll push a batch of changes, then I believe this is ready to merge!
StephanTLavavej
approved these changes
Feb 20, 2021
Member
|
I've reported DevCom-1344701 "Spaceship operator return type using pack expansion emits bogus error C2672". |
CaseyCarter
approved these changes
Feb 22, 2021
Member
|
Thanks for spaceship-izing these major parts of Clause 20, and finding a compiler bug along the way! 🛸 🪲 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes workaround for DevCom-583764 / VSO-900973 "
operator<=>is not called if there is an operator that returns a pointer", fixed by MSVC-PR-286030 on Nov 9, 2020.