P1391R4 "Range Constructor for string_view" #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Aug 29, 2020
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
After i actually read the constraints I am convinced this is really correct
CaseyCarter
commented
Aug 29, 2020
mnatsuhara
approved these changes
Aug 31, 2020
mnatsuhara
approved these changes
Aug 31, 2020
StephanTLavavej
requested changes
Sep 1, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good but I'd like to see constexpr tested.
StephanTLavavej
approved these changes
Sep 2, 2020
Contributor
Author
|
Thanks for this enormous contribution; this must have taken nearly an hour! |
Closed
Contributor
|
Looking at your output this week that equals about 5 algorithms and 3 CPOs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #39.