Revert "Implement common_iterator (#1092)" #1265
Merged
+13
−926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 30e7a1b.
StephanTLavavej
approved these changes
Sep 4, 2020
cbezault
approved these changes
Sep 4, 2020
Contributor
Author
|
Thanks for your untribution! |
CaseyCarter
added a commit
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 30e7a1b.
I inadvertently left
common_iteratorout of the internal merge PR - and it has occurrences of_Has_op_arrowthat are breaking everything here. We need to revert it, finish merging the other "Ready to Merge" PRs which have merged internally, and then re-mergecommon_iteratorhere and internally to unbreak the STL.