Skip to content

Conversation

@StephanTLavavej
Copy link
Member

Followups to GH-1344 requested by @cbezault.

  • xutility
    • Extract && !defined(_M_ARM64EC) to the end for clarity. There's no behavioral change here (_M_ARM64EC can be defined only when _M_X64 is defined), it just separates the major architectures where we want to enable the vectorized algorithms (x86, x64) from the flavors where they should be excluded due to intrinsic unavailability.
  • stl/msbuild/stl_base/msvcp.settings.targets
  • stl/msbuild/stl_atomic_wait/stl_atomic_wait.files.settings.targets
    • Add and remove semicolons for consistency.
  • vector_algorithms.cpp
    • Adjust preprocessor guards. We never build this for /clr:pure, so that can be a hard #error. However, we do need to make this file a no-op for _M_ARM64EC. Extract that, like xutility above.

I tested this with MSVC-internal builds of x86, x64, arm, arm64, and chpe (there is no dedicated arm64ec build).

(Recreated yet again, hopefully Azure Pipelines will work now.)

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 8, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner October 8, 2020 02:34
@CaseyCarter CaseyCarter self-assigned this Oct 8, 2020
@CaseyCarter CaseyCarter merged commit a6c1042 into microsoft:master Oct 9, 2020
@CaseyCarter
Copy link
Contributor

Thanks for all five of your contributions, and for displaying the level of tenacity the STL requires!

@CaseyCarter
Copy link
Contributor

Thanks for all five of your contributions, and for displaying the level of tenacity the STL requires! (I don't think there's much here to Changelog.)

@CaseyCarter CaseyCarter removed their assignment Oct 9, 2020
@StephanTLavavej StephanTLavavej deleted the arm64ec_followup_v5 branch October 9, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants