Implement ranges::take_while_view #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CaseyCarter
suggested changes
Oct 29, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
I'm sure some of these comments will be stomped since you've been updating while I'm reviewing - I'll do a followup and make sure nothing gets lost.
CaseyCarter
reviewed
Oct 29, 2020
CaseyCarter
suggested changes
Oct 30, 2020
CaseyCarter
approved these changes
Oct 30, 2020
Contributor
Author
|
@CaseyCarter, you are too fast Thanks for a lazy evening for me ;) |
StephanTLavavej
requested changes
Nov 4, 2020
StephanTLavavej
approved these changes
Nov 4, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Member
|
I'll take a moment while merging this batch of PRs to say that in my view, the rest of this pun is left as an exercise to the reader. 😼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #39
Note I still need to write an LWG issue for the precondition on
end()