Fix inconsistencies in range adaptor tests #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan noticed a `move` missing from a line of code that meant to `move(as_const(rng))` while reviewing `common_view`. This bug (and for the most part, another similar bug nearby) came from the `views::all` test and propagated through _all_ of the range adaptor tests.
Contributor
Author
|
I've also audited the in-flight view adaptor tests and submitted correction comments. |
Contributor
|
Urgh sorry for not catching that. These tests are unfortunately too complex to be easily reviewable |
mnatsuhara
approved these changes
Oct 26, 2020
StephanTLavavej
approved these changes
Oct 27, 2020
StephanTLavavej
added
test
Member
|
Thanks for fixing this test bug! 🪲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stephan noticed a
movemissing from a line of code that meant tomove(as_const(rng))while reviewingcommon_view. This bug (and for the most part, another similar bug nearby) came from theviews::alltest and propagated through all of the range adaptor tests.