Skip to content

Shrink DLL 2% by removing dead code for Windows XP #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 5 commits into from
Nov 4, 2020
Merged

Shrink DLL 2% by removing dead code for Windows XP #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84cbde6
Remove WINDOWS_XP from P0218R1_filesystem/test.cpp.
StephanTLavavej Oct 23, 2020
157cb17
Remove non-exported Windows XP machinery from winapinls.cpp.
StephanTLavavej Oct 23, 2020
877969c
Improve winapinls.cpp build throughput.
StephanTLavavej Oct 23, 2020
b1b44cd
Drop "Machinery to test the XP codepath".
StephanTLavavej Oct 23, 2020
84957c4
Drop comments about Vista versus XP.
StephanTLavavej Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions stl/src/filesystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,7 @@ void __stdcall __std_fs_directory_iterator_close(_In_ const __std_fs_dir_handle

if (_Code_page == __std_code_page{CP_UTF8} || _Code_page == __std_code_page{54936}) {
// For UTF-8 or GB18030, attempt to use WC_ERR_INVALID_CHARS. (These codepages can't use WC_NO_BEST_FIT_CHARS
// below, and other codepages can't use WC_ERR_INVALID_CHARS.) WC_ERR_INVALID_CHARS is Windows Vista+.
// Windows XP will activate the ERROR_INVALID_FLAGS fallback below.
// below, and other codepages can't use WC_ERR_INVALID_CHARS.)
_Result._Len = WideCharToMultiByte(static_cast<unsigned int>(_Code_page), WC_ERR_INVALID_CHARS, _Input_str,
_Input_len, _Output_str, _Output_len, nullptr, nullptr);
} else { // For other codepages, attempt to use WC_NO_BEST_FIT_CHARS.
Expand Down
Loading