Skip to content

Updated _MSVC_STL_UPDATE to November 2020 #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Nov 14, 2020
Merged

Updated _MSVC_STL_UPDATE to November 2020 #1439

StephanTLavavej merged 1 commit into from
Nov 14, 2020

Conversation

@avinal
Copy link
Contributor

@avinal avinal commented Nov 10, 2020

Closes #1438

@avinal avinal requested a review from a team as a code owner November 10, 2020 16:05
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Nov 10, 2020
CaseyCarter
CaseyCarter approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 11, 2020

Status update: we'll merge this soon. Currently we need to simultaneously merge changes on GitHub and our Microsoft-internal repo that exactly mirrors this (and builds the product that ships to customers); as this is a manual process, we batch up PRs in a "ready to merge" state to reduce the work needed.

@StephanTLavavej StephanTLavavej self-assigned this Nov 13, 2020
@StephanTLavavej StephanTLavavej merged commit 8b6e960 into microsoft:master Nov 14, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 14, 2020

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 😸

@avinal
Copy link
Contributor Author

avinal commented Nov 14, 2020

Thanks @StephanTLavavej , I hope there will be more contributions soon 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@mnatsuhara mnatsuhara mnatsuhara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to November 2020

4 participants

@avinal @StephanTLavavej @CaseyCarter @mnatsuhara