Skip to content

LWG-3460 Unimplementable noop_coroutine_handle guarantees #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 8 commits into from
Dec 2, 2020
Merged

LWG-3460 Unimplementable noop_coroutine_handle guarantees #1452

StephanTLavavej merged 8 commits into from
Dec 2, 2020

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Nov 12, 2020

No description provided.

@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Nov 12, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner November 12, 2020 05:39
@CaseyCarter CaseyCarter linked an issue Nov 12, 2020 that may be closed by this pull request
LWG-3460 Unimplementable noop_coroutine_handle guarantees #1453
Closed
@CaseyCarter CaseyCarter mentioned this pull request Nov 12, 2020
Closed
52 tasks
cpplearner
cpplearner reviewed Nov 12, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej changed the title Implement LWG-3460 LWG-3460 Unimplementable noop_coroutine_handle guarantees Nov 18, 2020
@StephanTLavavej StephanTLavavej self-assigned this Nov 18, 2020
@StephanTLavavej StephanTLavavej removed their assignment Nov 20, 2020
@cbezault cbezault self-assigned this Nov 30, 2020
StephanTLavavej
StephanTLavavej requested changes Dec 1, 2020
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Dec 1, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 1, 2020

@CaseyCarter @cbezault I pushed one last change to verify the noexceptness of the explicit operator bool.

@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Dec 2, 2020

@CaseyCarter @cbezault I pushed one last change to verify the noexceptness of the explicit operator bool.

Ditto: I symmetrically verified the noexceptness of coroutine_handle<>'s conversion to bool for consistency with the other operations.

@StephanTLavavej StephanTLavavej self-assigned this Dec 2, 2020
@StephanTLavavej StephanTLavavej merged commit 39ee107 into microsoft:master Dec 2, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 2, 2020

Thanks for implementing these unimplementable guarantees! 😹

@CaseyCarter CaseyCarter deleted the lwg3460 branch December 3, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@cpplearner cpplearner cpplearner left review comments

@cbezault cbezault cbezault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

LWG Library Working Group issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LWG-3460 Unimplementable noop_coroutine_handle guarantees

4 participants

@CaseyCarter @StephanTLavavej @cbezault @cpplearner