LWG-3036 polymorphic_allocator::destroy is extraneous #1455
+51
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By defining `polymorphic_allocator::destroy` - despite that it's equivalent to the default in `allocator_traits` - as deprecated. Also hack up the internal `_Has_no_alloc_destroy` trait so our optimization that avoids calling `destroy` on trivially destructible types keeps working with `polymorphic_allocator`. Fixes microsoft#1454.
52 tasks
miscco
reviewed
Nov 12, 2020
CaseyCarter
commented
Nov 12, 2020
CaseyCarter
changed the title
Add missing spaces. Cite LWG-3036. Add parens after functions.
StephanTLavavej
approved these changes
Dec 3, 2020
Member
|
Looks good to me, thanks for implementing this (especially the
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cbezault
approved these changes
Dec 3, 2020
Member
|
Thanks again for implementing this user-requested member function, deprecating it so users will decide they don't want it after all 😹, and ensuring that the STL continues to generate efficient code! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining
polymorphic_allocator::destroy- despite that it's equivalent to the default inallocator_traits- as deprecated. Also hack up the internal_Has_no_alloc_destroytrait so our optimization that avoids callingdestroyon trivially destructible types keeps working withpolymorphic_allocator.Fixes #1454 and fixes #753.