LWG-3448 transform_view's sentinel<false> not comparable with iterator<true> #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Found the error sitting in front of the monitor. Now I only need to add tests for the different |
StephanTLavavej
changed the title
52 tasks
Contributor
Author
|
This should be ready for review now |
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good - I'll resolve the merge conflicts and push fixes for the superficial things I found.
StephanTLavavej
approved these changes
Nov 20, 2020
CaseyCarter
approved these changes
Dec 2, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
There's a small whitespace fix here which I'll go ahead and apply.
Remove extra empty line.
StephanTLavavej
approved these changes
Dec 3, 2020
Member
|
Thanks for transforming the STL to be even more conformant! 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I may be stupid, but I cannot understand why
ranges::endis suddenly invalid.This is essentially the same problem I have with
join_view@CaseyCarter please point out the obvious
Fixes #1462.