Add a pragma comment to pull in the synchronization lib #1507
Conversation
cbezault
added
bug
|
AFAIK this only resolves the second case, where it can't find the Windows functions. I don't think that the first broken case, which can't find __std_atomic_wait_direct and friends, will be fixed. |
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
I'm fine with this change but not with the suggestion that it completely fixes the linked bug - as @sylveon commented. There's some linker funkiness - either a bug in the ARM linker or some unsupported behavior on x86 that we're taking advantage of - that still needs addressing.
That said, I'd be happy to go ahead and approve this as an improvement that partially addresses but does not close #1504.
|
|
||
| #if _ATOMIC_WAIT_ON_ADDRESS_STATICALLY_AVAILABLE | ||
|
|
||
| #pragma comment(lib, "synchronization") |
There was a problem hiding this comment.
I thought we had this comment, but it was replaced with linking using CMakeList.txt.
@BillyONeal , do you remeber anything relevant to this?
There was a problem hiding this comment.
The final binary which links against the atomic_wait.obj needs to also know to link in the synchronization.lib. It is insufficient to just link against the synchronization.lib at build time.
There was a problem hiding this comment.
It is insufficient to just link against the
synchronization.libat build time.
Do I understand correctly that this isn't a problem for x86/x64 because _ATOMIC_WAIT_ON_ADDRESS_STATICALLY_AVAILABLE is zero because they have to support Windows 7? (I should have asked this in my review instead of simply assuming.)
There was a problem hiding this comment.
Yes, _ATOMIC_WAIT_ON_ADDRESS_STATICALLY_AVAILABLE is zero on x86/x64
|
@CaseyCarter I updated the original issue with information concerning the linking issue. It appears to be a separate issue that I reached out to Jimmy to confirm. |
|
Thanks for fixing this linker error! Your fix will ship in VS 2019 16.9 Preview 3. 🚢 🐈 |
5 participants
Works towards #1504.