Skip to content

charconv internal functions for wchar_t buffers #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barcharcraz merged 8 commits into from
Feb 4, 2021
Merged

charconv internal functions for wchar_t buffers #1587

barcharcraz merged 8 commits into from
Feb 4, 2021

Conversation

@MattStephanson
Copy link
Contributor

@MattStephanson MattStephanson commented Jan 25, 2021

Fixes #1569.

@MattStephanson MattStephanson requested a review from a team as a code owner January 25, 2021 07:39
miscco
miscco reviewed Jan 25, 2021
View reviewed changes
@cbezault

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej added enhancement Something can be improved format C++20/23 format labels Jan 26, 2021
MattStephanson
MattStephanson commented Jan 26, 2021
View reviewed changes
barcharcraz
barcharcraz reviewed Jan 26, 2021
View reviewed changes
Base automatically changed from master to main January 28, 2021 00:35
@MattStephanson
code review feedback
23b022d 
 - actually call wide Ryu functions
 - Widen __[df]2s_buffered_n
 - Don't wrap memcpy calls.
 - Use ternary operator and cast for static widen.
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 3, 2021

I believe that this should be retargeted to feature/format as only <format> needs these widened codepaths, and there is no other ongoing work in <charconv> that will conflict - let's make sure that all of the necessary widening is suitable for <format> before the final merge into main.

@StephanTLavavej StephanTLavavej changed the base branch from main to feature/format February 4, 2021 04:39
StephanTLavavej
StephanTLavavej reviewed Feb 4, 2021
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Feb 4, 2021
@barcharcraz barcharcraz merged commit dfb9396 into microsoft:feature/format Feb 4, 2021
@MattStephanson MattStephanson deleted the gh-1569 branch February 14, 2021 01:06
@AdamBucior AdamBucior mentioned this pull request Apr 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+4 more reviewers

@CaseyCarter CaseyCarter CaseyCarter left review comments

@miscco miscco miscco left review comments

@AdamBucior AdamBucior AdamBucior left review comments

@barcharcraz barcharcraz barcharcraz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@barcharcraz barcharcraz

Labels

enhancement Something can be improved format C++20/23 format

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<charconv>: allow output to wchar_t buffers

7 participants

@MattStephanson @cbezault @StephanTLavavej @CaseyCarter @barcharcraz @miscco @AdamBucior