Add test coverage for GH-1603 (default_initializable) #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft#1603 reports a new failure mode for the `default_initializable` concept when compiling with MSVC. This PR adds a test case which is disabled for MSVC with links to the pertinent compiler bug DevCom-1326684. Drive-by: Also replace references to VSO-1084668 with the corresponding public DevCom-952724.
StephanTLavavej
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
added
test
StephanTLavavej
approved these changes
Feb 5, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
LGTM. We'll be able to use MSVC_INTERNAL_TESTING to handle the time between the bugs being fixed internally and shipping in VS Preview.
Contributor
Author
Yes, |
cbezault
approved these changes
Feb 12, 2021
Member
|
Thanks for reporting this compiler bug and adding corresponding test coverage! 🪲 🔎 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1603 reports a new failure mode for the
default_initializableconcept when compiling with MSVC. This PR adds a test case which is disabled for MSVC with links to the pertinent compiler bug DevCom-1326684.Drive-by: