Skip to content

Implement a packed format store #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barcharcraz merged 37 commits into from
Feb 12, 2021
Merged

Implement a packed format store #1625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5191e21
Noralize next_arg_id
miscco Jan 29, 2021
6a4ff26
Add precondition check to basic_format_parse_context::advance_to and …
miscco Jan 29, 2021
be1afc0
ensure basic_format_parse_context::check_arg_id is not a constant exp…
miscco Jan 29, 2021
ae417d7
Add tests for basic_format_parse_context
miscco Jan 29, 2021
cbea0a5
Fix constant expression check
miscco Jan 29, 2021
ba63570
Not not
miscco Jan 29, 2021
816fe40
windsdk is bad
miscco Jan 29, 2021
5485658
Address review comments
miscco Jan 30, 2021
e938cfa
Use a non constexpr function call with a better name
miscco Jan 31, 2021
31b1599
Create a packed _Format_arg_store
miscco Feb 2, 2021
94f7109
We want bits not bytes
miscco Feb 5, 2021
6fc4e47
No shadowing
miscco Feb 5, 2021
6e46b07
Dont use friendship
miscco Feb 5, 2021
2700e2a
Remove all int128 code
miscco Feb 5, 2021
dd88cc0
Fix some bugs
miscco Feb 5, 2021
218ffc1
Who doesnt hate max/min
miscco Feb 5, 2021
abb61b1
Copy&Paste does not like ODR
miscco Feb 5, 2021
c23e34c
Address review comments
miscco Feb 6, 2021
56f92fc
Merge branch 'feature/format' into format_store
miscco Feb 6, 2021
bed9329
Minor fixes
miscco Feb 6, 2021
a4a8be6
Move make_format_args down
miscco Feb 6, 2021
71bf674
Use auto
miscco Feb 6, 2021
2843417
Some more fixes
miscco Feb 6, 2021
0f4b962
Everyone can be a wchar_t if he just believe in it
miscco Feb 6, 2021
ef8eea4
Add {unsigned} long tests
miscco Feb 6, 2021
d50f51d
Int is in our hearts
miscco Feb 7, 2021
a152b99
Remove duplication
miscco Feb 7, 2021
87b4851
Move _CharType alias into function to unblock the build
miscco Feb 8, 2021
3caf20e
First round of review comments
miscco Feb 10, 2021
c5c8bbc
Use variable template rater than function
miscco Feb 10, 2021
f3c91d0
Add warning
miscco Feb 10, 2021
8afe67b
Make a proper constructor of _Format_arg_store
miscco Feb 11, 2021
06cb9e9
Use a single contiguous array to store the `_Format_arg_store` data
miscco Feb 11, 2021
302ac20
Specialize empty `_Format_arg_store`
miscco Feb 11, 2021
9f85da5
More review comments
miscco Feb 12, 2021
70fc37b
Fix uninitialized memory
miscco Feb 12, 2021
76b8a55
Properly initialize the first Index
miscco Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading