<format>: initial replacement field tests (and numeric arg indexing) #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barcharcraz
added
cxx20
StephanTLavavej
approved these changes
Feb 23, 2021
| assert(output_string == "}x"); | ||
|
|
||
| output_string.clear(); | ||
| vformat_to(back_insert_iterator(output_string), locale::classic(), "{}", make_format_args((const char*) "f")); |
Member
There was a problem hiding this comment.
We conventionally avoid C-style casts everywhere (because they can do so many things, and are impossible to search for). Occurs below.
Contributor
There was a problem hiding this comment.
I would also say, that we should fix the bug and not try to work around it
Contributor
Author
There was a problem hiding this comment.
We're going to merge and fix the bug in a PR, just because that unblocks Elnar and I have to get a foot X-Ray before fixing the overload set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds simple tests for replacement fields and arg-id based indexing.
some fun facts:
make_format_args("f")does not work because format_args_store doesn't understand char (&)[N]. This is a bug that's probably a very simple fix in format_arg_store (a decay_t around line 845 is probably all that's needed). I want to talk to miscco first to see if there's anything I'm missing but I'll have a PR that does that tonight if possible.