Improve coroutine_handle visualization with intrinsics #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the visualization of `std::coroutine_handle`. These are implemented by native visualization code and will require an updated Visual Studio to work. All take the frame pointer `_Ptr` as an argument. * `primary_function` returns the address of the user coroutine function. This is used in the display name of the coroutine_handle to indicate with which coroutine it is associated instead of the compiler-generated resume function. * `suspend_point` returns the suspend point index at which the coroutine is currently suspended. The natvis rules will display friendly names for the special suspend points for initial (1) and final (0, -1) suspend. * `suspend_point_line` returns the line number of the current suspend point. This requires additional debugging info in the .PDB which is not present in the initial compiler releases with standard coroutine support. The natvis rules will omit the line number if it's not available.
CaseyCarter
approved these changes
Mar 29, 2021
StephanTLavavej
approved these changes
Mar 29, 2021
Member
|
Thanks for improving this visualizer and making coroutines significantly more usable! 🎉 😸 👁️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the visualization of
std::coroutine_handle. These areimplemented by native visualization code and will require an updated
Visual Studio to work. All take the frame pointer
_Ptras an argument.primary_functionreturns the address of the user coroutine function.This is used in the display name of the
coroutine_handleto indicatewith which coroutine it is associated instead of the compiler-generated
resume function.
suspend_pointreturns the suspend point index at which the coroutineis currently suspended. The natvis rules will display friendly names
for the special suspend points for initial (1) and final (0, -1) suspend.
suspend_point_linereturns the line number of the current suspendpoint. This requires additional debugging info in the .PDB which is
not present in the initial compiler releases with standard coroutine
support. The natvis rules will omit the line number if it's not available.