<chrono>: Add %j support and expand %aAuw #1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds %j support to all the classes that can benefit from it. This means all year_month_day* but and month_last (but only for January). Changes %aAuw to throw on invalid weekdays, but still work if the weekday is explicitly ok (so a bad year_month_day will always throw but a bad year_month_weekday can still print the weekday if that portion is ok).
mnatsuhara
reviewed
Apr 20, 2021
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
One lingering question, but otherwise looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds %j support to all the classes that can benefit from it.
This means all year_month_day* but and month_last (but only for
January).
Changes %aAuw to throw on invalid weekdays, but still work if the
weekday is explicitly ok (so a bad year_month_day will always throw but
a bad year_month_weekday can still print the weekday if that portion is
ok).