<ranges> Invalidate the cached position of a view after move #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
commented
May 26, 2021
miscco
commented
May 26, 2021
miscco
commented
May 26, 2021
StephanTLavavej
requested changes
Jun 2, 2021
CaseyCarter
suggested changes
Aug 4, 2021
CaseyCarter
approved these changes
Aug 4, 2021
AdamBucior
reviewed
Aug 5, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good - I'll go ahead and push superficial changes.
StephanTLavavej
approved these changes
Aug 5, 2021
Member
|
FYI @CaseyCarter I pushed trivial changes after you approved, to fix the issues that @AdamBucior and I identified. |
CaseyCarter
approved these changes
Aug 5, 2021
Member
|
Thanks for fixing this bug! 🐛 😸 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should invalidate the cached position after a move