Repairing counted_iterator
#1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Jun 21, 2021
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
We also need a P2259R1 banner under "_HAS_CXX20 directly controls" in <yvals_core.h> with a partial completion indicator:
// P2259R1 Repairing Input Range Adaptors And counted_iterator
// (partially implemented)Co-authored-by: Casey Carter <cartec69@gmail.com>
CaseyCarter
approved these changes
Jun 22, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good - I'll validate and push changes for const style and difference_type test coverage.
StephanTLavavej
approved these changes
Jun 23, 2021
CaseyCarter
approved these changes
Jun 23, 2021
Member
|
Thanks for implementing the Standard's usability fixes for ranges! 😻 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
counted_iteratorpart of WG21-P2259.Partially addresses #1684.