<streambuf>: fix seekpos and seekoff
#2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celonymire
approved these changes
Aug 13, 2021
StephanTLavavej
added
bug
StephanTLavavej
removed
the
decision needed
Member
|
We talked about this at the weekly maintainers meeting and we believe that this is a reasonable direction to take. |
StephanTLavavej
approved these changes
Aug 20, 2021
Member
|
I'm mirroring this to an MSVC-internal PR. Changes can still be pushed during final review, but please notify me if that happens. |
CaseyCarter
approved these changes
Aug 26, 2021
Member
|
Thanks for fixing this (presumably) decades-old bug! 🐞 😺 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2120