Adding mutex, ranges, functional, any and format visualizers #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
reviewed
Sep 9, 2021
AdamBucior
reviewed
Sep 9, 2021
AdamBucior
reviewed
Sep 9, 2021
AnjuDel
force-pushed
the
mutex_visualizer
branch
from
f0b82a6 to
4d056be
Compare
AlexGuteniev
approved these changes
Sep 10, 2021
AnjuDel
changed the title
AnjuDel
changed the title
AnjuDel
changed the title
barcharcraz
reviewed
Nov 23, 2021
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
requested changes
May 6, 2022
Contributor
strega-nil-ms
left a comment
strega-nil-ms
left a comment
There was a problem hiding this comment.
Other than that, I want to see @StephanTLavavej's comments fixed first before doing a full review.
TODO: figure out if the format_args stuff can be fixed
Contributor
|
@StephanTLavavej could you re-take a look? |
StephanTLavavej
requested changes
Jul 6, 2022
StephanTLavavej
approved these changes
Jul 6, 2022
Member
|
For reference, VS-PR-407223 is still active, porting #2784, #2804, and #2811 (MSVC-PR-407231). Marking this PR as blocked until we either clear the pipeline or decide to add this PR to the triple-mirror. VS-PR-408482 / MSVC-PR-409524 / #2843 are merged. |
StephanTLavavej
added
blocked
Member
|
Let's try mirroring this and sorting out the VS-PR later. I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks @AnjuDel and @strega-nil-ms for visualizing all of these types! 👓 🎉 😸 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…ft#2191) Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding visualizers for missing mutex elements and more.
Fixes #929.
From @strega-nil-ms: additionally, refactor
std::tuple's visualizer.