Skip to content

Implement LWG-3574 and LWG-3595: common_iterator should be completely constexpr-able #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 9 commits into from
Dec 17, 2021
Merged

Implement LWG-3574 and LWG-3595: common_iterator should be completely constexpr-able #2410

StephanTLavavej merged 9 commits into from
Dec 17, 2021

Conversation

@fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Dec 12, 2021 •
edited
Loading

Fixes #2397

Fixes #2264

@fsb4000 fsb4000 requested a review from a team as a code owner December 12, 2021 13:14
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges labels Dec 12, 2021
StephanTLavavej
StephanTLavavej reviewed Dec 14, 2021
View reviewed changes
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 14, 2021

Thanks! I added a missing constexpr and test coverage to verify it. (Had to modify poor_sentinel since we need a non-trivial copy ctor to activate the codepath.)

@fsb4000 fsb4000 changed the title Implement LWG-3574: common_iterator should be completely constexpr-able Implement LWG-3574 and 3595: common_iterator should be completely constexpr-able Dec 14, 2021
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Dec 14, 2021

I am pretty sure we do not use constexpr on defaulted SMF

When the Working Draft says constexpr (even when it doesn't matter) we repeat it (for consistency).

CaseyCarter
CaseyCarter suggested changes Dec 14, 2021
View reviewed changes
@StephanTLavavej StephanTLavavej changed the title Implement LWG-3574 and 3595: common_iterator should be completely constexpr-able Implement LWG-3574 and LWG-3595: common_iterator should be completely constexpr-able Dec 15, 2021
CaseyCarter
CaseyCarter reviewed Dec 15, 2021
View reviewed changes
@CaseyCarter
Update tests/std/tests/P0896R4_common_iterator/test.cpp
1d6eae0 
Test constexpr copy construction with a stored sentinel whose copy constructor is constexpr but not trivial
@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 16, 2021

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4db457f into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 17, 2021

Thanks for implementing a fourth and fifth LWG issue resolution in today's batch! 🤯 💥 😻

@fsb4000 fsb4000 deleted the fix2397 branch December 17, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+3 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@AlexGuteniev AlexGuteniev AlexGuteniev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

LWG Library Working Group issue ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

5 participants

@fsb4000 @StephanTLavavej @CaseyCarter @miscco @AlexGuteniev