P1413R3 Deprecate aligned_storage & aligned_union#2583
Merged
StephanTLavavej merged 16 commits intomicrosoft:mainfrom May 17, 2022
Merged
P1413R3 Deprecate aligned_storage & aligned_union#2583StephanTLavavej merged 16 commits intomicrosoft:mainfrom
aligned_storage & aligned_union#2583StephanTLavavej merged 16 commits intomicrosoft:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
fsb4000
reviewed
Feb 20, 2022
Contributor
frederick-vs-ja
left a comment
frederick-vs-ja
left a comment
There was a problem hiding this comment.
It seems that the non-deprecated copy is not needed, but I'm not sure.
# Conflicts: # tests/libcxx/expected_results.txt # tests/libcxx/skipped_tests.txt # tests/libcxx/usual_matrix.lst
fsb4000
added a commit
to fsb4000/STL
that referenced
this pull request
May 7, 2022
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks, this looks great! I found only nitpicks, so I'll validate and push changes soon.
StephanTLavavej
approved these changes
May 12, 2022
CaseyCarter
approved these changes
May 12, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 16, 2022
Member
|
Thanks for implementing this C++23 feature and helping to modernize the ecosystem! 🧑🚀 🚀 🪐 |
This was referenced May 26, 2022
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2533
Internal use in
mutex/condition_variable/node_handle- is fixed by creating a non-deprecated copy.I'm not sure why we quote the deprecating paper, as we don't quote the WP merged papers elsewhere; but I followed the precedent.