Skip to content

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Apr 13, 2022

  • Unskip three_way_comparable.compile.pass.cpp as it's now passing with 17.2 Preview 3.
  • Add workarounds to P1502R1_standard_library_header_units for VSO-1496084 "Standard Library Header Units: Splitting <chrono> emits fatal error C1116: unrecoverable error importing header unit '<chrono>'"
    • This has already been fixed in 17.3 Preview 2, so we can run the affected code when defined(_MSVC_INTERNAL_TESTING).
    • It also repros only for separate header units, so we can run the affected code when defined(TEST_TOPO_SORT) (deduplicated header units).
  • Remove workaround for VSO-1049320 "conditional operator errors" in P0784R7_library_support_for_more_constexpr_containers.
  • Toolset update:
    • 17.2 Preview 3 (now required, as the internal toolset has also been updated).
    • Python 3.10.4.
    • This contains Clang 13.0.1, so we can upgrade the WinSDK. The latest is the Windows 11 SDK.
    • Patch Tuesday.
  • Remove /Gm- and /ZH:SHA_256.
    • MSVC-PR-392417 "Remove logic related to /Gm": "The flag is ignored starting from 17.0. This PR removes its related logic."
      • We don't need to explicitly disable something that can't be enabled.
    • MSVC-PR-334618 "Make SHA-256 the default source hash algorithm" merged 2021-06-30.

StephanTLavavej and others added 6 commits April 13, 2022 00:45
* MSVC-PR-392417 "Remove logic related to /Gm": "The flag is ignored starting from 17.0. This PR removes its related logic."
  + We don't need to explicitly disable something that can't be enabled.
* MSVC-PR-334618 "Make SHA-256 the default source hash algorithm" merged 2021-06-30.
  + https://docs.microsoft.com/en-us/cpp/build/reference/zh?view=msvc-170 says: "/ZH:SHA_256 Use an SHA-256 hash for the checksum. This option is the default in Visual Studio 2022 version 17.0 and later."
  + `cl /?` was updated too: `/ZH:[MD5|SHA1|SHA_256] hash algorithm for calculation of file checksum in debug info (default: SHA_256)`
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Apr 13, 2022
@StephanTLavavej StephanTLavavej marked this pull request as ready for review April 13, 2022 21:00
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 13, 2022 21:00
@CaseyCarter CaseyCarter self-assigned this Apr 13, 2022
@CaseyCarter CaseyCarter removed their assignment Apr 13, 2022
@StephanTLavavej
Copy link
Member Author

@CaseyCarter I pushed a comment change after your approval as I just learned that 17.3 Preview 2 will be the next release containing compiler front-end changes.

@StephanTLavavej StephanTLavavej self-assigned this Apr 15, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit fa02b10 into microsoft:main Apr 16, 2022
@StephanTLavavej StephanTLavavej deleted the toolset-update branch April 16, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Related to repository automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants