Annotate some functions _MSVC_CONSTEXPR
#2658
Conversation
Which is meaningless now, but will eventually become `[[msvc::constexpr]]`. This mirrors internal MSVC-PR-391437.
| #endif // _ENABLE_STL_INTERNAL_CHECK | ||
|
|
||
| #ifndef _MSVC_CONSTEXPR // TRANSITION, VS2022v17.3p2 | ||
| #define _MSVC_CONSTEXPR |
There was a problem hiding this comment.
Can we move that to the other custom attributes? Even if it has no value right now?
There was a problem hiding this comment.
Does it need to be now, or would a followup be ok? I plan a followup to better integrate this with #2649 (move _HAS_MSVC_ATTRIBUTE to VCRuntime so it's used consistently for all of the _MSVC_MEOW attribute macros) and I'll bring it all together then.
There was a problem hiding this comment.
Not a hill I would die on.
It is a bit icky to add something with the goal to clean it up afterwards, but I can appreciate that it has a dependency on VCRuntime so its fine by me
There was a problem hiding this comment.
It is a bit icky to add something with the goal to clean it up afterwards, but I can appreciate that it has a dependency on VCRuntime so its fine by me
I'm also trying to avoid repeated CI cycles as things move back-and-forth between PRs, and trying to keep the compiler Devs unblocked. This is correct but not in the final form we'd like, which I'm happy to call good enough to decouple future library work from the ongoing compiler PR.
StephanTLavavej
changed the title
_MSVC_CONSTEXPR
|
Thanks for mirroring these compiler changes! 🪞 ⚙️ 😸 |
3 participants
Which is meaningless now, but will eventually become
[[msvc::constexpr]]when VCRuntime changes (and the corresponding compiler) ship.This mirrors internal MSVC-PR-391437.