Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<deque>,<forward_list>,<list>: Usenullptrinstead of_Mapptr()and_Nodeptr().nullptris even clearer.nullptrwith these types:STL/stl/inc/deque
Line 771 in ea32e86
STL/stl/inc/forward_list
Line 841 in ea32e86
STL/stl/inc/list
Line 445 in ea32e86
<array>,<tuple>: We don't needreturnafter calling_Left.swap(_Right);.<chrono>,<complex>,<format>: Use direct-init instead ofType var = Type{init};which repeats theTypeunnecessarily.<memory_resource>:_STL_INTERNAL_STATIC_ASSERTs instead of user-visiblestatic_asserts before everystatic_cast. (This is internal machinery, so we're just checking our own work here. I believe that this code may have predated the introduction of_STL_INTERNAL_STATIC_ASSERT.)_Intrusive_listcomment for consistency with_Intrusive_stack._Remove(), we don't needaddressof()for raw pointers._Foo(a meaningless name, which we conventionally avoid, especially in product code) to_Pnext(which is used in similar loops, and is actually somewhat descriptive here - except at the very beginning, it is pointing to a_Next).<experimental/filesystem>: Drop// TRANSITION, ABI,#if 0code._Path_cvt<value_type, char32_t>resulted in compiler errors, which we had hopes of someday fixing, or which perhaps were actually fixed by the codecvt_ids overhaul. In any event, there is no reason to attempt to enable these functions now. In vNext, we will simply eradicate<experimental/filesystem>.string_type(1, _FS_PREF)cannot be changed, as that would attempt to construct a sequence of 2 characters (guess how I found out):STL/stl/inc/experimental/filesystem
Line 1086 in ea32e86