Implement P2494R2 Relaxing Range Adaptors To Allow Move-Only Types #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHY IS initializer_list NOT A VIEWABLE_RANGE
StephanTLavavej
requested changes
Aug 2, 2022
this also makes the tests better, imo
StephanTLavavej
requested changes
Aug 2, 2022
StephanTLavavej
approved these changes
Aug 3, 2022
Member
|
Thanks, this looks good! I pushed one last round of trivial nitpicks. Now we just need to merge the blocking PR. |
Member
|
This is now unblocked. 🎉 |
StephanTLavavej
approved these changes
Aug 23, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Aug 26, 2022
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
One issue which I have a fix for. I've updated the issues for both P2321R2 an P2474R2 to indicate that their components have changes in P2494R2.
StephanTLavavej
approved these changes
Aug 26, 2022
Member
|
Thanks for implementing this feature - now we can finally relax! 😹 🏖️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2934
Needs test coverageBlocked on #2661 (both update__cpp_lib_ranges)