Skip to content

Conversation

@SiliconA-Z
Copy link
Contributor

No description provided.

@SiliconA-Z SiliconA-Z requested a review from a team as a code owner September 7, 2022 13:06
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Sep 7, 2022
@StephanTLavavej
Copy link
Member

Thanks, and good catch! This is indeed static, and we're within the class itself here, so there's no reason to access it like a non-static data member:

__PURE_APPDOMAIN_GLOBAL static _Locimp* _Clocptr;

@StephanTLavavej
Copy link
Member

Also, I checked and this appears to be the only occurrence.

@StephanTLavavej StephanTLavavej self-assigned this Sep 12, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7fb1539 into microsoft:main Sep 13, 2022
@StephanTLavavej
Copy link
Member

Thanks for this code cleanup! 😸 😸 😸

@SiliconA-Z SiliconA-Z deleted the Clocptr branch September 26, 2022 16:08
CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants