Skip to content

Remove unneeded static casts #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Sep 13, 2022
Merged

Remove unneeded static casts #3086

StephanTLavavej merged 1 commit into from
Sep 13, 2022

Conversation

@SiliconA-Z
Copy link
Contributor

@SiliconA-Z SiliconA-Z commented Sep 7, 2022

We already know that __n, __j, and __m are already integers, so there is no need to use static casts

@SiliconA-Z SiliconA-Z requested a review from a team as a code owner September 7, 2022 13:18
@SiliconA-Z
Remove unneeded static casts
3f06947 
We already know that __n, __j, and __m are already integers, so there is no need to use static casts
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Sep 8, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 8, 2022

Thanks, good catches. The static_cast removals are definitely great. We often use auto after static_cast to avoid repeating the (sometimes complicated/lengthy) type, but int is the simplest and shortest there is, so I believe that this is reasonable.

@StephanTLavavej StephanTLavavej mentioned this pull request Sep 8, 2022
Closed
@StephanTLavavej StephanTLavavej self-assigned this Sep 12, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 12, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 7eea1bf into microsoft:main Sep 13, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 13, 2022

Thanks for this code cleanup! 😸 😸 😸 😸 😸

@SiliconA-Z SiliconA-Z deleted the static-cast branch September 26, 2022 16:08
CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Oct 6, 2022
@SiliconA-Z @CaseyCarter
Remove unneeded static casts (microsoft#3086)
40cc06b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+4 more reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@AraHaan AraHaan AraHaan approved these changes

@frederick-vs-ja frederick-vs-ja frederick-vs-ja approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SiliconA-Z @StephanTLavavej @CaseyCarter @AraHaan @frederick-vs-ja @strega-nil-ms