Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Feb 22, 2023

Fixes #3014.

Library parts affected by this issue:

  • move_sentinel<S> (two constructors),
  • transform_view<R, F>::_Iterator,
  • join_view<R>::_Iterator,
  • join_with_view<R, P>::_Iterator (two constructors),
  • join_with_view<R, P>::_Sentinel
  • elements_view<R, N>::_Iterator.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner February 22, 2023 15:21
@CaseyCarter CaseyCarter added bug Something isn't working ranges C++20/23 ranges labels Feb 22, 2023
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StephanTLavavej
Copy link
Member

Also thanks! I pushed a commit to delete 3 redundant lines, FYI @strega-nil-ms.

@StephanTLavavej StephanTLavavej self-assigned this Feb 24, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

Thanks again for finding and fixing these occurrences of this bug! 🛠️ 🐞 ✨

@JMazurkiewicz JMazurkiewicz deleted the fix_ranges_lst_init branch February 26, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<ranges>: list-initialization is misused

4 participants