Skip to content

<mdspan>: Use concepts everywhere and add mdspan deduction guides #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 2 commits into from
Mar 14, 2023
Merged

<mdspan>: Use concepts everywhere and add mdspan deduction guides #3564

StephanTLavavej merged 2 commits into from
Mar 14, 2023

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Mar 13, 2023

  • Replace (almost) all uses of enable_if with concepts,
  • Add missing mdspan deduction guides.

Drive-by:

  • Remove unnecessary includes,
  • Remove 2 non-standard constructors (one from layout_stride::mapping and one from mdspan),
  • Improve some comments,

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 13, 2023 08:54
strega-nil-ms
strega-nil-ms reviewed Mar 13, 2023
View reviewed changes
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Mar 13, 2023
StephanTLavavej
StephanTLavavej approved these changes Mar 14, 2023
View reviewed changes
@StephanTLavavej StephanTLavavej merged commit 187a036 into microsoft:feature/mdspan2 Mar 14, 2023
@JMazurkiewicz JMazurkiewicz deleted the mdspan/all-concepts branch March 14, 2023 00:36
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Mar 14, 2023

Thanks for the high-concept PR! 😻

JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 17, 2023
@JMazurkiewicz
Restore <type_traits> include in <mdspan> header
c9a884c 
See comment: microsoft#3564 (comment)
@JMazurkiewicz JMazurkiewicz mentioned this pull request Mar 17, 2023
Merged
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 25, 2023
@JMazurkiewicz
layout_left: cleanup names
d289efa 
Partially addresses microsoft#3564 (comment)
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 25, 2023
@JMazurkiewicz
layout_left: cleanup names
3dc3965 
Partially addresses microsoft#3564 (comment)
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 25, 2023
@JMazurkiewicz
layout_right: cleanup names
ada70c4 
Partially addresses microsoft#3564 (comment)
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 25, 2023
@JMazurkiewicz
layout_stride: cleanup names
f517852 
Partially addresses microsoft#3564 (comment)
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+3 more reviewers

@jovibor jovibor jovibor left review comments

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mdspan C++23 mdspan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JMazurkiewicz @StephanTLavavej @jovibor @frederick-vs-ja @strega-nil-ms