Skip to content

Conversation

@JMazurkiewicz
Copy link
Contributor

Addresses #3586 (comment).

  • Remove _Dynamic_index (N4944: dynamic-index) and _Dynamic_index_inv (N4944: dynamic-index-inv) exposition-only functions and use _Dynamic_indices and _Dynamic_indices_inv arrays directly,
  • Add new static variables to extents: _Rank and _Rank_dynamic,
  • Replace execution-time calls to rank, rank_dynamic, or static_extent with direct variable accesses,
  • Remove warning suppression in _Make_dynamic_indices.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner April 26, 2023 14:27
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Apr 26, 2023
@StephanTLavavej
Copy link
Member

@JMazurkiewicz Thanks for these improvements! There are merge conflicts with your other changes (both git-detected and stealth, it appears), enough that I'm uncomfortable with attempting to fix them myself.

@StephanTLavavej StephanTLavavej self-assigned this Apr 27, 2023
@StephanTLavavej StephanTLavavej merged commit e4fb8fa into microsoft:feature/mdspan2 Apr 27, 2023
@JMazurkiewicz JMazurkiewicz deleted the mdspan/debug-experience branch April 27, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mdspan C++23 mdspan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants