Skip to content

Implement <flat_set> #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 26 commits into from
Jun 22, 2023
Merged

Implement <flat_set> #3817

StephanTLavavej merged 26 commits into from
Jun 22, 2023

Conversation

@Saalvage
Copy link
Contributor

@Saalvage Saalvage commented Jun 21, 2023 •
edited by StephanTLavavej
Loading

Sadly, tests are mostly missing!

Works towards #2912.

@Saalvage Saalvage requested a review from a team as a code owner June 21, 2023 00:35
@StephanTLavavej StephanTLavavej added the flat_meow C++23 container adaptors label Jun 21, 2023
frederick-vs-ja
frederick-vs-ja reviewed Jun 21, 2023
View reviewed changes
Saalvage and others added 2 commits June 21, 2023 03:36
@Saalvage
Merge branch 'main' into feature/flat_set
0433292
@Saalvage @frederick-vs-ja
Clean up minor issues
a807eb6 
Co-Authored-By: A. Jiang <23228989+frederick-vs-ja@users.noreply.github.com>
AlexGuteniev
AlexGuteniev suggested changes Jun 21, 2023
View reviewed changes
StephanTLavavej
StephanTLavavej requested changes Jun 21, 2023
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@Saalvage @StephanTLavavej @AlexGuteniev
CXX23 guards
fb1bf79 
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
Co-Authored-By: Alex Guteniev <3995422+alexguteniev@users.noreply.github.com>
@Saalvage

This comment was marked as resolved.

Sign in to view
Saalvage and others added 3 commits June 22, 2023 01:23
@Saalvage @AlexGuteniev
Down with typename
577dd6a 
Co-Authored-By: Alex Guteniev <3995422+alexguteniev@users.noreply.github.com>
@Saalvage
Fix _EXPORT_STD location
7b448fb
@Saalvage
Oops, format!
caf825b
StephanTLavavej
StephanTLavavej reviewed Jun 22, 2023
View reviewed changes
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jun 22, 2023

Thanks! I fully reviewed all of the supporting files, and lightly reviewed <flat_set> and its test.cpp. (I'll do a more thorough review later, of course.) I've pushed changes for the superficial issues I found, and I'll merge this after the tests pass, so other contributors can begin looking into it.

@StephanTLavavej StephanTLavavej merged commit d8ef55d into microsoft:feature/flat_set Jun 22, 2023
@Saalvage Saalvage deleted the feature/flat_set branch June 22, 2023 16:02
@grcm10 grcm10 mentioned this pull request Oct 2, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@AlexGuteniev AlexGuteniev AlexGuteniev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flat_meow C++23 container adaptors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Saalvage @StephanTLavavej @AlexGuteniev @frederick-vs-ja @strega-nil-ms