`constexpr` `mutex` constructor #3824

cpplearner · 2023-06-23T10:00:07Z

Because this might cause problem in complicated (and formally forbidden) scenarios (see discussion in #3770), I chose to make this opt-in via the _USE_CONSTEXPR_MUTEX_CONSTRUCTOR macro. If _USE_CONSTEXPR_MUTEX_CONSTRUCTOR is not defined, mutex will call _Mtx_init_in_situ as before.

For the same reason, I changed stl_critical_section_win7 and stl_condition_variable_win7 back to polymorphic classes, even though their vptrs are no longer accessed. (If _USE_CONSTEXPR_MUTEX_CONSTRUCTOR is defined, no stl_critical_section_win7 object will be created.)

tests/std/tests/VSO_0226079_mutex/test.cpp

stl/inc/mutex

stl/inc/xthreads.h

stl/src/primitives.hpp

StephanTLavavej · 2023-07-07T04:41:04Z

Thanks, this looks great! I pushed extremely minor changes.

Having thought about this extensively during the previous PR, I think that this change is correct and safe, and it's a good simplification too.

stl/inc/mutex

StephanTLavavej · 2023-07-13T08:55:37Z

Unfortunately, I need to pull this from the merge batch. It's causing the internal build to consistently fail with:

D:\msvc\src\vctools\asan\mt\llvm-symbolizer.nativeproj(79,5): error MSB3073:
The command ""D:\msvc\src\ExternalAPIs\cmake\bin\ninja.exe" "bin/llvm-symbolizer.exe"   " exited with code 1.

I don't know what's causing this yet.

StephanTLavavej · 2023-07-13T22:09:11Z

We're very close to understanding the root cause - the MSVC-internal build is using fresh STL headers, but a previously installed copy of msvcp140.dll on the system. The fix will also be MSVC-internal; it appears that this PR is working by design (we knew that it would require an updated DLL).

CaseyCarter · 2023-07-13T22:14:45Z

We're very close to understanding the root cause - the MSVC-internal build is using fresh STL headers, but a previously installed copy of msvcp140.dll on the system. The fix will also be MSVC-internal; it appears that this PR is working by design (we knew that it would require an updated DLL).

In other words: Thanks for finding a bug in our internal build!

StephanTLavavej · 2023-07-14T01:26:05Z

We'll need to ensure that the VCRedist is unlocked for this.

StephanTLavavej · 2023-07-19T21:18:59Z

⚠️ Note to self: This requires MSVC-internal changes...

... found by @zacklj89 (:heart_eyes_cat:); I will investigate adding a complete set of DLLs to that list.

@MahmoudGSaleh will notify the appropriate people that 17.8 Preview 2 needs to have an unlocked VCRedist.

It turns out that the STL requires you to place the DLLs into the directory of the executable; else, msvcp140.dll will be taken from C:\Windows\System32 (which is unsupported). This was discovered because of the recent constexpr mutex change; see [microsoft/STL#3824][]. Especially the fuzzer unit tests fail completely with the mutex changes. [microsoft/STL#3824]: microsoft/STL#3824 Differential Revision: https://reviews.llvm.org/D158221

This reverts commit 8d18fec. Conflicts: * stl/inc/xthreads.h * stl/src/cond.cpp * stl/src/mutex.cpp * stl/src/primitives.hpp

@snnn

microsoft/STL#3824 introduces constexpr mutex. An older version of msvcp140.dll will lead to ```A dynamic link library (DLL) initialization routine failed```. This error can be encountered if using conda Python since conda packages msvc dlls and these are older right now. This PR disables the constexpr mutex so that ort package can work with older msvc dlls. Thanks @snnn for the discovery.

@snnn

microsoft/STL#3824 introduces constexpr mutex. An older version of msvcp140.dll will lead to ```A dynamic link library (DLL) initialization routine failed```. This error can be encountered if using conda Python since conda packages msvc dlls and these are older right now. This PR disables the constexpr mutex so that ort package can work with older msvc dlls. Thanks @snnn for the discovery.

@snnn

microsoft/STL#3824 introduces constexpr mutex. An older version of msvcp140.dll will lead to ```A dynamic link library (DLL) initialization routine failed```. This error can be encountered if using conda Python since conda packages msvc dlls and these are older right now. This PR disables the constexpr mutex so that ort package can work with older msvc dlls. Thanks @snnn for the discovery.

microsoft/STL#3824 microsoft/STL#4000 microsoft/STL#4339 Add escape hatch due to STL change resulting in issues with binary compatibility. https://github.com/microsoft/STL/wiki/Changelog "Fixed bugs: Fixed mutex's constructor to be constexpr. #3824 #4000 #4339 Note: Programs that aren't following the documented restrictions on binary compatibility may encounter null dereferences in mutex machinery. You must follow this rule: When you mix binaries built by different supported versions of the toolset, the Redistributable version must be at least as new as the latest toolset used by any app component. You can define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as an escape hatch."

STL updates Mutex Fix microsoft/STL#3824 microsoft/STL#4000 microsoft/STL#4339 Add escape hatch due to STL change resulting in issues with binary compatibility. https://github.com/microsoft/STL/wiki/Changelog "Fixed bugs: Fixed mutex's constructor to be constexpr. #3824 #4000 #4339 Note: Programs that aren't following the documented restrictions on binary compatibility may encounter null dereferences in mutex machinery. You must follow this rule: When you mix binaries built by different supported versions of the toolset, the Redistributable version must be at least as new as the latest toolset used by any app component. You can define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as an escape hatch."**Description**

See [MSVC-PR-490940][] and [LLVM-D158221][]. It turns out that the STL requires you to place the DLLs into the directory of the executable; else, `msvcp140.dll` will be taken from `C:\Windows\System32` (which is unsupported). This was discovered because of the recent constexpr mutex change; see [microsoft/STL#3824][]. Especially the fuzzer unit tests fail completely with the mutex changes. [MSVC-PR-490940]: https://dev.azure.com/devdiv/DevDiv/_git/msvc/pullrequest/490940 [LLVM-D158221]: https://reviews.llvm.org/D158221 [microsoft/STL#3824]: microsoft/STL#3824

@SaiyansKing

Merge SaiyansKing readme changes and workaround for old "critical section" usage, update readme - Add Linux Wine Example - Update readme - @SaiyansKing fixed possible crash with mutex usage on newer c++: > VS 2022 17.10: > > - Fixed bugs: > - Fixed mutex's constructor to be constexpr. [#3824](microsoft/STL#3824) [#4000](microsoft/STL#4000) [#4339](microsoft/STL#4339) Note: Programs that aren't following the documented [restrictions on binary compatibility](https://learn.microsoft.com/en-us/cpp/porting/binary-compat-2015-2017?view=msvc-170) may encounter null dereferences in mutex machinery. You must follow this rule: When you mix binaries built by different supported versions of the toolset, the Redistributable version must be at least as new as the latest toolset used by any app component. > > - You can define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as an escape hatch.

@snnn

microsoft/STL#3824 introduces constexpr mutex. An older version of msvcp140.dll will lead to ```A dynamic link library (DLL) initialization routine failed```. This error can be encountered if using conda Python since conda packages msvc dlls and these are older right now. This PR disables the constexpr mutex so that ort package can work with older msvc dlls. Thanks @snnn for the discovery.

@snnn

microsoft/STL#3824 introduces constexpr mutex. An older version of msvcp140.dll will lead to ```A dynamic link library (DLL) initialization routine failed```. This error can be encountered if using conda Python since conda packages msvc dlls and these are older right now. This PR disables the constexpr mutex so that ort package can work with older msvc dlls. Thanks @snnn for the discovery.

constexpr mutex

3803814

cpplearner requested a review from a team as a code owner June 23, 2023 10:00

cpplearner marked this pull request as draft June 23, 2023 10:27

Fix

b497d9e

cpplearner marked this pull request as ready for review June 23, 2023 11:01

Fix

6b8e353

frederick-vs-ja reviewed Jun 23, 2023

View reviewed changes

tests/std/tests/VSO_0226079_mutex/test.cpp Show resolved Hide resolved

stl/inc/mutex Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

StephanTLavavej added the bug Something isn't working label Jun 23, 2023

StephanTLavavej self-assigned this Jun 23, 2023

cpplearner and others added 3 commits June 24, 2023 15:05

Address review comments

83dbc72

Test constinit

b85f626

Code review feedback.

bcdfcb0

StephanTLavavej reviewed Jul 7, 2023

View reviewed changes

stl/inc/mutex Outdated Show resolved Hide resolved

stl/inc/xthreads.h Outdated Show resolved Hide resolved

stl/src/primitives.hpp Outdated Show resolved Hide resolved

StephanTLavavej approved these changes Jul 7, 2023

View reviewed changes

StephanTLavavej removed their assignment Jul 7, 2023

frederick-vs-ja mentioned this pull request Jul 7, 2023

STL.natvis: Simplify visualization for mutex/recursive_mutex #3848

Merged

strega-nil-ms reviewed Jul 7, 2023

View reviewed changes

stl/inc/mutex Show resolved Hide resolved

strega-nil-ms approved these changes Jul 7, 2023

View reviewed changes

StephanTLavavej self-assigned this Jul 13, 2023

This comment was marked as outdated.

Sign in to view

StephanTLavavej removed their assignment Jul 13, 2023

StephanTLavavej added the affects redist Results in changes to separately compiled bits label Jul 14, 2023

StephanTLavavej self-assigned this Jul 20, 2023

achabense mentioned this pull request Aug 16, 2023

Logic cleanups for basic_string #3862

Merged

CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Aug 30, 2023

Revert "constexpr mutex constructor (microsoft#3824)"

dc550c4

This reverts commit 8d18fec. Conflicts: * stl/inc/xthreads.h * stl/src/cond.cpp * stl/src/mutex.cpp * stl/src/primitives.hpp

CaseyCarter mentioned this pull request Aug 30, 2023

Make the constexpr mutex constructor opt-in #4000

Merged

CaseyCarter mentioned this pull request Jan 23, 2024

<mutex> : enable constexpr default constructor by, err, default #4338

Closed

past-due mentioned this pull request Jun 6, 2024

New unexpected build failures on 20240603.1.0 actions/runner-images#10004

Closed

14 tasks

MDMS24 mentioned this pull request Jun 9, 2024

[BUG] new Microsoft Visual C++ 2015-2022 Redistributable requires #define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR bshoshany/thread-pool#151

Closed

This was referenced Jun 11, 2024

Define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR microsoft/onnxruntime#21005

Merged

Define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR microsoft/onnxruntime-genai#599

Merged

cpplearner mentioned this pull request Jun 17, 2024

VCRuntime incompatibility with older version in mutex code #4730

Closed

narknon mentioned this pull request Jun 27, 2024

STL updates Mutex Fix UE4SS-RE/RE-UE4SS#580

Merged

2 tasks

Airyzz mentioned this pull request Jul 12, 2024

Windows release only working with debug .dll files media-kit/media-kit#892

Closed

TwoCanPlugIn mentioned this pull request Jul 20, 2024

For Windows versions, use updated redistributables OpenCPN/OpenCPN#4063

Open

Bonfra04 mentioned this pull request Aug 2, 2024

fix: Disabled constexpr mutex constructor to fix Windows build crashes. Skyost/Bonsoir#100

Merged

StephanTLavavej mentioned this pull request Sep 23, 2024

Mutex.h: BREAKING CHANGE - DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR #4978

Closed

assarbad mentioned this pull request Oct 13, 2024

windirstat crashes after scanning C drive windirstat/windirstat#93

Closed

mos9527 mentioned this pull request Oct 29, 2024

astc-encoder-py causes Blender crashes on specific systems mos9527/sssekai_blender_io#11

Closed

kryksyh mentioned this pull request Nov 10, 2024

Fix crash in release build on certain runtime combinations saintmatthieu/loop-tempo-estimator#4

Closed

StephanTLavavej mentioned this pull request Feb 1, 2025

On the ABI compatibility of std::future #5260

Closed

kirides mentioned this pull request May 8, 2025

Merge SaiyansKing readme changes and workaround for old "critical section" usage, update readme kirides/GD3D11#191

Merged

echoix mentioned this pull request Jun 12, 2025

[Bug] install of WinGRASS-8.5dev-a277d8547c-18-Setup VCRUNTIME140.dll not found error OSGeo/grass#5663

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`constexpr` `mutex` constructor #3824

`constexpr` `mutex` constructor #3824

Uh oh!

cpplearner commented Jun 23, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Jul 7, 2023

Uh oh!

Uh oh!

This comment was marked as outdated.

StephanTLavavej commented Jul 13, 2023

Uh oh!

StephanTLavavej commented Jul 13, 2023

Uh oh!

CaseyCarter commented Jul 13, 2023

Uh oh!

StephanTLavavej commented Jul 14, 2023

Uh oh!

StephanTLavavej commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

constexpr mutex constructor #3824

constexpr mutex constructor #3824

Uh oh!

Conversation

cpplearner commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

StephanTLavavej commented Jul 7, 2023

Uh oh!

Uh oh!

This comment was marked as outdated.

StephanTLavavej commented Jul 13, 2023

Uh oh!

StephanTLavavej commented Jul 13, 2023

Uh oh!

CaseyCarter commented Jul 13, 2023

Uh oh!

StephanTLavavej commented Jul 14, 2023

Uh oh!

StephanTLavavej commented Jul 19, 2023

⚠️ Note to self: This requires MSVC-internal changes...

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

`constexpr` `mutex` constructor #3824

`constexpr` `mutex` constructor #3824

cpplearner commented Jun 23, 2023 •

edited

Loading