Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Aug 17, 2023

Unblocks one libcxx test for MSVC.

I found that DevCom-1559808 is fixed during working on _STD-/_RANGES-qualifying _Ugly function names.
(And I've realized that structured bindings for pair/subrange involve ADL, so I'm planning changing the return type of _Partition_by_median_guess_common to something like meow_result).

Edit: I was wrong. DevCom-1559808 isn't totally fixed.

Edit: I've filed DevCom-10452846 "Customized structured binding of subrange that refers to dynamic buffer incorrectly causes constant evaluation failure" for the remain issue.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner August 17, 2023 17:37
@achabense

This comment was marked as off-topic.

@frederick-vs-ja frederick-vs-ja changed the title Remove workaround for DevCom-1559808 Partially remove workaround for DevCom-1559808 Aug 17, 2023
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Aug 24, 2023
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's here is good, but it's incomplete. DevCom-1559808 is closed as "fixed", so we need to remove any and all transition comments citing that bug. If we don't, we have TRANSITION comments waiting to respond to an event that is never going to happen. In practice that means we need to rereduce the issue that the remaining workaround in <algorithm> avoids, file that repro as a new DevCom bug, and update the bug number in the TRANSITION comment.

@StephanTLavavej
Copy link
Member

Thanks! The "no workaround" / "workaround" system is so great for making these changes easy to review.

@CaseyCarter CaseyCarter self-assigned this Aug 29, 2023
@CaseyCarter
Copy link
Contributor

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter merged commit bbb6739 into microsoft:main Aug 31, 2023
@CaseyCarter
Copy link
Contributor

Thanks for helping to keep the code clean of workarounds for fixed bugs.

@frederick-vs-ja frederick-vs-ja deleted the no-workaround-1559808 branch August 31, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants