Skip to content

Conversation

@kissholic
Copy link
Contributor

@kissholic kissholic commented Sep 1, 2023

Fixes #4001

@kissholic kissholic requested a review from a team as a code owner September 1, 2023 02:28
@fsb4000
Copy link
Contributor

fsb4000 commented Sep 1, 2023

Edit your first post to Fixes #4001

Copy link
Contributor

@celonymire celonymire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the title of the PR is probably meant to say "September" :)

@CaseyCarter CaseyCarter changed the title Update _MSVC_STL_UPDATE to August 2023 Update _MSVC_STL_UPDATE to September 2023 Sep 1, 2023
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Sep 1, 2023
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good. I've changed "August" to "September" in the title, and added "Fixes #4001" to the description so the issue is linked to the PR (and will be automagically closed when the PR merges). Thanks!

@StephanTLavavej StephanTLavavej self-assigned this Sep 7, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d97e997 into microsoft:main Sep 7, 2023
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to September 2023

5 participants