Don't * every test matrix line
#4240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 283cf32.
... to avoid running in both `std` and `stdasan`.
StephanTLavavej
approved these changes
Dec 5, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
0 out of 5 stars, would not merge again! 😹 🤪 🚫 ⭐ |
Contributor
Author
Oh no, my Yelp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal test runner runs
*-tagged lines when asked to run lines with any particular tag, includingASAN. Putting*on everything is not the clever hack we thought it was, it results in the internalASANpipeline running everything. We don't need this redundant coverage so we need to revert #4068.This change includes three commits for ease of review:
*tags to all non-tagged configs #4068 (this was purely mechanical, so feel free to skim),*tags that Add*tags to all non-tagged configs #4068 added to non-leaf lines, which were actually necessary bug fixes,P2465R3_standard_library_modulesso all fourteen configurations aren't run in both ASan and non-ASan pipelines.I validated these changes by running each of
std,tr1,libcxxboth internally and externally with and without the change to verify that the correct number of tests are run in every case.