Skip to content

<flat_map>: Re-enable /permissive with miscellaneous fixes and test coverage #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 4 commits into from
Feb 12, 2024
Merged

<flat_map>: Re-enable /permissive with miscellaneous fixes and test coverage #4386

StephanTLavavej merged 4 commits into from
Feb 12, 2024

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Feb 11, 2024 •
edited
Loading

Towards #2910. Addresses some comments in #4337.

Product code fixes for <flat_map>.

  • Proper _EXPORT_STD.
  • Simplify the template head of _Flat_map_base.
  • _NODISCARD and _NODISCARD_FRIEND.
  • Drop leading typename in the namespace scope.
  • Re-enable /permissive mode by changing _Insert_exact calls.
    • Perhaps we should change _Insert_exact in the future.
  • Avoid double guarding in _Erase_if.
  • Turn doubtful accociated constraints into _STL_INTERNAL_STATIC_ASSERT.

Test coverage for modules with <flat_map>.

Test coverage unique to <flat_map>.

  • SCARY-ness test reforming.
  • Proper this->template test coverage.
  • Re-enable /permissive.

@frederick-vs-ja
Product code fixes for <flat_map>
9b02e88 
- Proper `_EXPORT_STD`.
- `_NODISCARD` and `_NODISCARD_FRIEND`.
- Drop leading `typename` in the namespace scope.
- Re-enable `/permissive` mode by changing `_Insert_exact` calls.
- Avoid double guarding in `_Erase_if`.
- Turn doubtful accociated constraints into
`_STL_INTERNAL_STATIC_ASSERT`.
@frederick-vs-ja
Test coverage - modules with <flat_map>
d150999
@frederick-vs-ja
Test coverage unique to <flat_map>
a76cd72 
- SCARY-ness test reforming.
- Proper `this->template` test coverage.
- Enabling `/permissive`.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 11, 2024 18:19
@StephanTLavavej StephanTLavavej added bug Something isn't working flat_meow C++23 container adaptors labels Feb 11, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 11, 2024
StephanTLavavej
StephanTLavavej approved these changes Feb 12, 2024
View reviewed changes
@StephanTLavavej StephanTLavavej merged commit 5687099 into microsoft:feature/flat_map Feb 12, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Feb 12, 2024

Thanks! I have another round of comments for follow-up.

@frederick-vs-ja frederick-vs-ja deleted the flat_map-permissive-2 branch February 12, 2024 18:26
@frederick-vs-ja frederick-vs-ja mentioned this pull request Mar 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working flat_meow C++23 container adaptors

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frederick-vs-ja @StephanTLavavej