Implement formatter specializations for pair and tuple
#4438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage mainly rely on unblocked libcxx tests.
StephanTLavavej
added
ranges
and re-enable fixed `_STL_INTERNAL_STATIC_ASSERT`
- std/containers/sequences/vector.bool/vector.bool.fmt/parse.pass.cpp - std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp
cpplearner
reviewed
Mar 5, 2024
This comment was marked as resolved.
This comment was marked as resolved.
- Remove redundant `_Writer`. - Remove redundant `back_insert_iterator` variable. - Use `_Copy_unchecked`, removing `_Sv_formatter`. - Remove one superfluous `_Write_aligned` call.
* `std/utilities/format/format.tuple/format.functions.tests.h` * `std/utilities/format/format.tuple/format.functions.format.pass.cpp` * `std/utilities/format/format.tuple/format.functions.vformat.pass.cpp`
StephanTLavavej
approved these changes
Mar 15, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2919. Also partially implements LWG-3839 and LWG-3892.
Test coverage mainly relies on unblocked libcxx tests.
std/utilities/format/format.tuple/format.functions.format.pass.cppstd/utilities/format/format.tuple/format.functions.vformat.pass.cppstd/utilities/format/format.tuple/set_brackets.pass.cppstd/utilities/format/format.tuple/set_separator.pass.cppThere's one new test file added to the
stdsubdirectory that is derived from libcxx tests.The following ones would also be unblocked after this PR and LLVM-83734.
std/containers/sequences/vector.bool/vector.bool.fmt/parse.pass.cppstd/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cppstd/utilities/format/format.tuple/parse.pass.cpp