<random>: Implement Mandates for seed_seq::generate
#4447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Mar 5, 2024
Comment on lines
+182
to
+185
| static_assert(_Is_any_of_v<remove_cv_t<typename iterator_traits<_RanIt>::value_type>, // | ||
| unsigned int, unsigned long, unsigned long long>, | ||
| "N4971 [rand.util.seedseq]/7 requires the value type of the iterator to be an unsigned type that is at " | ||
| "least 32-bit."); |
Member
There was a problem hiding this comment.
No change requested: I wouldn't have used remove_cv_t here (elsewhere we assume that iterator_traits::value_type is cv-unqualified), and @CaseyCarter would have said "unsigned integer type" to match the Standard, but neither are worth resetting testing.
Contributor
Author
There was a problem hiding this comment.
Hmm... [fs.path.req]/2.2 currently accepts a const-qualified value_type, but [fs.req]/3 doesn't seem so. Perhaps there should be an LWG issue for this.
CaseyCarter
approved these changes
Mar 5, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for emitting more compiler errors! 🤖 ❌ 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4434.
Notes:
char32_tis excluded because it's not an "unsigned integer type" in the core language.remove_cv_tis used, which is related to CWG-251 (still open)._Iter_value_tis intentionally not used, see<xutility>: Evil memberelement_typecan break non-ranges algorithms since C++20 #4436.