Fix insert for flat_map and flat_multimap #4778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
reviewed
Jul 2, 2024
StephanTLavavej
added
bug
Contributor
Author
|
@StephanTLavavej Could you please take a look at this? Thanks! |
StephanTLavavej
approved these changes
Jul 10, 2024
Member
|
@duanqn Looks great, thanks! I pushed small cosmetic changes and I'll merge this after the tests pass. Apologies for not getting to this sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Flat_map_base::insertoverloads were hidden because of the additionalinsertoverloads defined in the children classes.Use
using _Mybase::insertto make them visible.Also add test cases.