Skip to content

Update C++20 section of <yvals_core.h> for WG21-P3136R1 Retiring Niebloids #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyCarter merged 1 commit into from
Dec 18, 2024
Merged

Update C++20 section of <yvals_core.h> for WG21-P3136R1 Retiring Niebloids #5191

CaseyCarter merged 1 commit into from
Dec 18, 2024

Conversation

@alexprabhat99
Copy link
Contributor

@alexprabhat99 alexprabhat99 commented Dec 16, 2024 •
edited
Loading

Fixes: #5138

@alexprabhat99 alexprabhat99 requested a review from a team as a code owner December 16, 2024 12:40
@alexprabhat99 alexprabhat99 changed the title update C++20 section of <yvals_core.h> for WG21-P3136R1 Retiring Niebloids Update C++20 section of <yvals_core.h> for WG21-P3136R1 Retiring Niebloids Dec 16, 2024
@CaseyCarter CaseyCarter self-assigned this Dec 16, 2024
@CaseyCarter CaseyCarter added ranges C++20/23 ranges cxx26 C++26 feature labels Dec 16, 2024
@CaseyCarter CaseyCarter removed their assignment Dec 16, 2024
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Dec 16, 2024

Thanks! We merge in batches, so don't be surprised if this sits for a bit before being merged.

@CaseyCarter CaseyCarter mentioned this pull request Dec 13, 2024
Open
@CaseyCarter CaseyCarter self-assigned this Dec 17, 2024
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Dec 17, 2024

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter merged commit 305346e into microsoft:main Dec 18, 2024
39 checks passed
@CaseyCarter
Copy link
Contributor

CaseyCarter commented Dec 18, 2024

Thanks for putting the final nail in the coffin of the brain-eating Niebloids. ⚰️ 🧟 🧠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CaseyCarter CaseyCarter

Labels

cxx26 C++26 feature ranges C++20/23 ranges

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P3136R1 Retiring Niebloids

3 participants

@alexprabhat99 @CaseyCarter @StephanTLavavej