Skip to content

Add support for running only edg tests #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaseyCarter merged 4 commits into from
Dec 18, 2024
Merged

Add support for running only edg tests #5194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
784165b
Add support for running only edg tests
jgoshi Dec 17, 2024
887201c
Casey's review comments
CaseyCarter Dec 17, 2024
1bd819e
Rename the target and flag for consistency
jgoshi Dec 17, 2024
ffe9d1b
Fix the name of the flag in one more place.
jgoshi Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ get_property(STL_LIT_TEST_DIRS GLOBAL PROPERTY STL_LIT_TEST_DIRS)

add_custom_target(STL-CI COMMAND ${STL_LIT_COMMAND} -Dnotags=ASAN ${STL_LIT_TEST_DIRS} USES_TERMINAL)
add_custom_target(STL-ASan-CI COMMAND ${STL_LIT_COMMAND} -Dtags=ASAN ${STL_LIT_TEST_DIRS} USES_TERMINAL)
add_custom_target(test-only-edg COMMAND ${STL_LIT_COMMAND} -Dnotags=ASAN -Dtest-only-edg=True --xunit-xml-output test-results.xml ${STL_LIT_TEST_DIRS} USES_TERMINAL)
3 changes: 3 additions & 0 deletions tests/utils/stl/test/params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ def beNice(prio: str) -> list[ConfigAction]:

def getDefaultParameters(config, litConfig):
DEFAULT_PARAMETERS = [
Parameter(name='test-only-edg', choices=[True, False], type=bool, default=False,
help="Whether to only run edg tests (those that use the /BE flag).",
actions=lambda enabled: [AddFeature(name='test-only-edg')] if enabled else []),
Parameter(name='long_tests', choices=[True, False], type=bool, default=True,
help="Whether to run tests that take a long time. This can be useful when running on a slow device.",
actions=lambda enabled: [AddFeature(name='long_tests')] if enabled else []),
Expand Down
7 changes: 5 additions & 2 deletions tests/utils/stl/test/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,12 @@ def configureTest(self, litConfig):
return Result(UNSUPPORTED, "Test does not require any of the features specified in limit_to_features: %s" %
msg)

if 'test-only-edg' in self.config.available_features and 'edg' not in self.requires:
return Result(UNSUPPORTED, 'We run only /BE tests with the test-only-edg flag')

if 'edg_drop' in self.config.available_features:
if not 'edg' in self.requires:
return Result(UNSUPPORTED, 'We only run /BE tests with the edg drop')
if 'edg' not in self.requires:
return Result(UNSUPPORTED, 'We run only /BE tests with the edg drop')

_, tmpBase = self.getTempPaths()
self.isenseRspPath = tmpBase + '.isense.rsp'
Expand Down