Expand workaround for EDG bug in P0323R12_expected
#5246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IntelliSense compiler just disabled compatibility with an outdated MSVC overload resolution bug, causing an apparent regression in `P0323R12_expected`. These `static_assert`s that were previously passing - but for the wrong reason - now fail with VS trunk. It looks a lot like VSO-1601179, so let's just expand the existing conditional to cover the new failures. Drive-by: Don't bother to implement some member functions that aren't ODR-used.
StephanTLavavej
approved these changes
Jan 22, 2025
Member
|
I have an active merge batch so I've copied this PR over to #5249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntelliSense compiler just disabled compatibility with an outdated MSVC overload resolution bug (the
do_ms_quirkbit in VS-PR-602338), causing an apparent regression inP0323R12_expected. Thesestatic_asserts that were previously passing - but for the wrong reason - now fail with VS trunk (apologies for this Microsoft-internal pipeline link, it's the newtest-edg-onlypipeline I helped the IntelliSense team put together). It looks a lot like VSO-1601179, so let's just expand the existing conditional to cover the new failures.Drive-by: Don't bother to implement some member functions that aren't ODR-used.