Skip to content

Conversation

@gabrielaugz
Copy link
Contributor

This PR updates the C++ Working Draft reference in README.md from N5001 to N5008.

This is a minor documentation update and does not affect the code or ABI.

Fixes #5342

@gabrielaugz gabrielaugz requested a review from a team as a code owner March 17, 2025 21:20
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 17, 2025
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Mar 17, 2025
@StephanTLavavej
Copy link
Member

Perfect, thank you! 😻

We merge PRs simultaneously to GitHub and our MSVC-internal repo in a semi-manual process, batched up to save time. Your PR will be part of the next batch, likely next week. I'll post comments here as I prepare your PR for merging.

@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 17, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Mar 21, 2025
@StephanTLavavej StephanTLavavej self-assigned this Mar 21, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request Mar 21, 2025
@gabrielaugz gabrielaugz force-pushed the update-readme-n5008 branch from 8166b9c to 07353a1 Compare March 24, 2025 19:37
@gabrielaugz
Copy link
Contributor Author

Hi! I only force-pushed to fix an incorrect commit author. The content remains the same.
Could you please review the commit again when possible? Thank you!

@StephanTLavavej
Copy link
Member

Thanks, that's fine as there are no content changes.

FYI, if you'd like to permanently associate another email address with your GitHub account, you can do so by adding it as a "secondary address" in your settings. That's what I do with my work and home addresses. Aside from having to confirm it, GitHub will continue to send email to your primary address only.

@StephanTLavavej StephanTLavavej merged commit 162a42b into microsoft:main Mar 25, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Mar 25, 2025
@StephanTLavavej
Copy link
Member

Thanks for updating this important link, and congratulations on your first microsoft/STL commit! 📜 😸 🎉

@gabrielaugz gabrielaugz deleted the update-readme-n5008 branch March 25, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

README.md: Update working draft revision to N5008

2 participants