<flat_map> and <flat_set>: Preliminary review cleanups
#5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
…s and deducing `this` (microsoft#5921)
Use angle brackets to distinguish `<vector>` as a header. Explicitly mention `<flat_map>` and `<flat_set>` for searchability.
Goodbye public `_Get_container_for_erase_if()`. Use CTAD and `this` for the `_Clear_guard`. Use `_Pass_fn` only at the outer layer.
StephanTLavavej
added
enhancement
github-project-automation
bot
moved this from Initial Review
to Done
in STL Code Reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainto pick up Various cleanups #5924, which cleaned up interleaved conditional includes.std.ixx: Avoid interleaving conditional includes.<vector>as a header.<flat_map>and<flat_set>for searchability.<vector>'s_Clear_guardshadows/supersedes_Hash::_Clear_guard.<flat_map>: Consistently use CTAD for_Clear_guard.<flat_set>: Consistently use CTAD andthis/_Otherfor_Clear_guard.flat_mapandflat_multimapdon't needusing _MyBase::_Erase_if;.<flat_set>: Centralize_Erase_if._Get_container_for_erase_if().thisfor the_Clear_guard._Pass_fnonly at the outer layer.<flat_map>:_Erase_ifand the friendship can be private to the base class.