Skip to content

Conversation

@vmichal
Copy link
Contributor

@vmichal vmichal commented Jan 8, 2026

Changed functionality:

  • Fix optimization of heterogeneous flat_map::erase(OtherKey&&) when OtherKey is not key_type .

Tests:

Progress towards https://discord.com/channels/737189251069771789/1120873380615295027/1450952672982204468

Also to exercise every deduction guide. [...] I want to make sure that every way we construct the container adaptors, we establish the invariants (so we actually-sort and actually-unique input when necessary).

@vmichal vmichal requested a review from a team as a code owner January 8, 2026 14:36
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Jan 8, 2026
@vmichal vmichal changed the title <flat_meow>: Add tests for all flat_map constructors, deduction guides and then some <flat_meow>: Add tests for all flat_map constructors, deduction guides and then some Jan 8, 2026
@vmichal vmichal changed the title <flat_meow>: Add tests for all flat_map constructors, deduction guides and then some <flat_meow>: Add tests for all flat_map constructors, deduction guides and then some Jan 8, 2026
@StephanTLavavej StephanTLavavej added test Related to test code flat_meow C++23 container adaptors labels Jan 8, 2026
@StephanTLavavej StephanTLavavej self-assigned this Jan 8, 2026
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej removed their assignment Jan 11, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Merging in STL Code Reviews Jan 11, 2026
@StephanTLavavej StephanTLavavej merged commit 7d6bac8 into microsoft:feature/flat_map Jan 11, 2026
45 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Jan 11, 2026
@StephanTLavavej
Copy link
Member

💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flat_meow C++23 container adaptors test Related to test code

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants